From d2f4f581bbdc46898158d4722ce47285bc5abf82 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carlos=20=C3=81lvaro?= <carlos@cdalvaro.io>
Date: Thu, 10 Nov 2022 18:39:52 +0100
Subject: [PATCH] fix(ci): Cannot share env variables between jobs

---
 .github/workflows/publish.yml | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 5a12a2f..bc4fb6e 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -25,8 +25,13 @@ jobs:
   metadata:
     name: Metadata
     runs-on: ubuntu-latest
+    outputs:
+      tags: ${{ steps.tags.outputs.tags }}
+      vcs_ref: ${{ steps.vcs_ref.outputs.vcs_ref }}
+      created_on: ${{ steps.created_on.outputs.created_on }}
     steps:
       - name: Image Tags
+        id: tags
         run: |
           IMAGE_TAG="${{ github.event.release.tag_name }}"
           [ -z "${IMAGE_TAG}" ] && IMAGE_TAG='latest'
@@ -41,19 +46,21 @@ jobs:
           echo "Docker image: '${DOCKER_IMAGE}'"
           echo "Tags: ${TAGS}"
 
-          echo "TAGS=${TAGS}" >> $GITHUB_ENV
+          echo "tags=${TAGS}" >> $GITHUB_OUTPUT
 
       - name: VCS ref
+        id: vcs_ref
         run: |
           VCS_REF="${GITHUB_SHA::8}"
           echo "VCS ref: ${VCS_REF}"
-          echo "VCS_REF=${VCS_REF}" >> $GITHUB_ENV
+          echo "vcs_ref=${VCS_REF}" >> $GITHUB_OUTPUT
 
       - name: Created On
+        id: created_on
         run: |
           CREATED_ON="$(date -u +"%Y-%m-%dT%H:%M:%SZ")"
           echo "Created on: ${CREATED_ON}"
-          echo "CREATED_ON=${CREATED_ON}" >> $GITHUB_ENV
+          echo "created_on=${CREATED_ON}" >> $GITHUB_OUTPUT
 
       - name: Dump environment
         if: contains(toJSON(github.event.commits.*.message), 'ci(debug)') == true
@@ -126,12 +133,12 @@ jobs:
           file: ./Dockerfile
           platforms: ${{ env.PLATFORMS }}
           build-args: |
-            VCS_REF=${{ env.VCS_REF }}
-            BUILD_DATE=${{ env.CREATED_ON }}
+            VCS_REF=${{ needs.metadata.outputs.vcs_ref }}
+            BUILD_DATE=${{ needs.metadata.outputs.created_on }}
           cache-from: |
             type=local,src=${{ env.CACHE_PATH }}
             ghcr.io/cdalvaro/docker-salt-master:latest
           cache-to: type=local,dest=${{ env.CACHE_PATH }}
           pull: true
           push: true
-          tags: ${{ env.TAGS }}
+          tags: ${{ needs.metadata.outputs.tags }}