implement basic exec [ci skip]

engine/linter/linter.go

@@ -139,6 +139,8 @@ func checkVolumes(pipeline *resource.Pipeline, trusted bool) error {
 			}
 		}
 		switch volume.Name {
+		case "":
+			return fmt.Errorf("linter: missing volume name")
 		case "workspace", "_workspace", "_docker_socket":
 			return fmt.Errorf("linter: invalid volume name: %s", volume.Name)
 		}

engine/linter/linter_test.go

@@ -30,6 +30,12 @@ func TestLint(t *testing.T) {
 			message: "linter: invalid or missing image",
 		},
 		// user should not use reserved volume names.
+		{
+			path:    "testdata/volume_missing_name.yml",
+			trusted: false,
+			invalid: true,
+			message: "linter: missing volume name",
+		},
 		{
 			path:    "testdata/volume_invalid_name.yml",
 			trusted: false,

engine/linter/testdata/volume_missing_name.yml

@@ -0,0 +1,18 @@
+---
+kind: pipeline
+type: docker
+name: linux
+
+steps:
+- name: test
+  image: golang
+  commands:
+  - go build
+  - go test
+
+services:
+- name: database
+  image: redis
+
+volumes:
+- temp: {}