- show reasonable errormessage in function validateFormFieldHidden() when hidden fields changed

- don't show error if cronjob-timestamps changed while editing settings, fixes #52
This commit is contained in:
Michael Kaufmann (d00p)
2010-03-09 06:45:36 +00:00
parent 8ec1b723a2
commit 1d03f04e1e
3 changed files with 13 additions and 4 deletions

View File

@@ -19,13 +19,20 @@
function validateFormFieldHidden($fieldname, $fielddata, $newfieldvalue)
{
if($newfieldvalue === $fielddata['value'])
{
/**
* don't show error on cronjob-timestamps changing
* because it might be possible that the cronjob ran
* while settings have been edited (bug #52)
*/
if($newfieldvalue === $fielddata['value']
|| $fieldname == 'system_last_tasks_run'
|| $fieldname == 'system_last_traffic_run'
|| $fieldname == 'system_lastcronrun'
) {
return true;
}
else
{
// TODO: Throw some error that actually makes sense - false would just throw unknown error
return false;
return 'hiddenfieldvaluechanged';
}
}