fix setting incorrect acme-challenge path on installation; fixes #1097

Signed-off-by: Michael Kaufmann <d00p@froxlor.org>

lib/Froxlor/Install/Install/Core.php

@@ -420,7 +420,7 @@ class Core
 		}
 
 		$this->updateSetting($upd_stmt, $this->validatedData['activate_newsfeed'], 'admin', 'show_news_feed');
-		$this->updateSetting($upd_stmt, dirname(__FILE__, 3), 'system', 'letsencryptchallengepath');
+		$this->updateSetting($upd_stmt, dirname(__FILE__, 5), 'system', 'letsencryptchallengepath');
 
 		// insert the lastcronrun to be the installation date
 		$this->updateSetting($upd_stmt, time(), 'system', 'lastcronrun');

lib/Froxlor/PhpHelper.php

@@ -324,7 +324,7 @@ class PhpHelper
 	 * Return human-readable sizes
 	 *
 	 * @param int $size size in bytes
-	 * @param string $max maximum unit
+	 * @param ?string $max maximum unit
 	 * @param string $system 'si' for SI, 'bi' for binary prefixes
 	 * @param string $retstring string-format
 	 *
@@ -332,7 +332,7 @@ class PhpHelper
 	 */
 	public static function sizeReadable(
 		int $size,
-		string $max = '',
+		?string $max = '',
 		string $system = 'si',
 		string $retstring = '%01.2f %s'
 	): string {