From 2748f1b6337f477af93bd62cee13546c2b3c4827 Mon Sep 17 00:00:00 2001 From: Michael Kaufmann Date: Sat, 6 Jun 2020 15:37:06 +0200 Subject: [PATCH] also display error when domain does not resolv to any A or AAAA record in lets-encrypt-dns-validation Signed-off-by: Michael Kaufmann --- lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php b/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php index a5cb15b2..cd2f2913 100644 --- a/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php +++ b/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php @@ -278,7 +278,7 @@ class AcmeSh extends \Froxlor\Cron\FroxlorCron $cronlog->logAction(FroxlorLogger::CRON_ACTION, LOG_INFO, "Validating DNS of " . $domain); // ips accordint to NS $domain_ips = PhpHelper::gethostbynamel6($domain); - if (count(array_intersect($our_ips, $domain_ips)) <= 0) { + if ($domain_ips == false || count(array_intersect($our_ips, $domain_ips)) <= 0) { // no common ips... $cronlog->logAction(FroxlorLogger::CRON_ACTION, LOG_WARNING, "Skipping Let's Encrypt generation for " . $domain . " due to no system known IP address via DNS check"); unset($domains[$idx]);