From 2b53c4b9181e75fcb5161c87817aab531997e084 Mon Sep 17 00:00:00 2001
From: Michael Kaufmann <d00p@froxlor.org>
Date: Thu, 24 Mar 2022 15:10:00 +0100
Subject: [PATCH] migrate phpinfo page

Signed-off-by: Michael Kaufmann <d00p@froxlor.org>
---
 admin_settings.php                           | 24 ++---------
 templates/Froxlor/settings/phpinfo.html.twig | 42 ++++++++++++++++++++
 2 files changed, 46 insertions(+), 20 deletions(-)
 create mode 100644 templates/Froxlor/settings/phpinfo.html.twig

diff --git a/admin_settings.php b/admin_settings.php
index 055c6251..4c0cf6c3 100644
--- a/admin_settings.php
+++ b/admin_settings.php
@@ -118,29 +118,13 @@ if ($page == 'overview' && $userinfo['change_serversettings'] == '1') {
 				$phpinfo[$end][] = $match[2];
 			}
 		}
-		$phpinfohtml = '';
-		foreach ($phpinfo as $name => $section) {
-			$phpinfoentries = "";
-			foreach ($section as $key => $val) {
-				if (is_array($val)) {
-					eval("\$phpinfoentries .= \"" . \Froxlor\UI\Template::getTemplate("settings/phpinfo/phpinfo_3") . "\";");
-				} elseif (is_string($key)) {
-					eval("\$phpinfoentries .= \"" . \Froxlor\UI\Template::getTemplate("settings/phpinfo/phpinfo_2") . "\";");
-				} else {
-					eval("\$phpinfoentries .= \"" . \Froxlor\UI\Template::getTemplate("settings/phpinfo/phpinfo_1") . "\";");
-				}
-			}
-			// first header -> show actual php version
-			if (strtolower($name) == "phpinfo") {
-				$name = "PHP " . PHP_VERSION;
-			}
-			eval("\$phpinfohtml .= \"" . \Froxlor\UI\Template::getTemplate("settings/phpinfo/phpinfo_table") . "\";");
-		}
-		$phpinfo = $phpinfohtml;
 	} else {
 		\Froxlor\UI\Response::standard_error($lng['error']['no_phpinfo']);
 	}
-	eval("echo \"" . \Froxlor\UI\Template::getTemplate("settings/phpinfo") . "\";");
+	UI::view('settings/phpinfo.html.twig', [
+		'phpversion' => PHP_VERSION,
+		'phpinfo' => $phpinfo
+	]);
 } elseif ($page == 'rebuildconfigs' && $userinfo['change_serversettings'] == '1') {
 	if (isset($_POST['send']) && $_POST['send'] == 'send') {
 
diff --git a/templates/Froxlor/settings/phpinfo.html.twig b/templates/Froxlor/settings/phpinfo.html.twig
new file mode 100644
index 00000000..3a5fee12
--- /dev/null
+++ b/templates/Froxlor/settings/phpinfo.html.twig
@@ -0,0 +1,42 @@
+{% extends "Froxlor/userarea.html.twig" %}
+
+{% block heading %}
+	<h5>
+		<i class="fa-solid fa-gears"></i>
+		{{ lng('admin.phpinfo') }}
+	</h5>
+{% endblock %}
+
+{% block content %}
+	<div class="card table-responsive">
+		<table class="table table-borderless table-striped align-middle mb-0 px-3">
+			<tbody>
+				{% for name,section in phpinfo %}
+					{% if name|lower == 'phpinfo' %}
+						{% set name = 'PHP ' ~ phpversion %}
+					{% endif %}
+					<tr>
+						<th colspan="3">{{ name|raw }}</th>
+					</tr>
+					{% for key,val in section %}
+						{% if key != 'Directive' %}
+							<tr>
+								{% if val is iterable %}
+									<td width="180">{{ key|raw }}</td>
+									<td colspan="2">{{ val[0]|raw }}<br/><small>(Master:
+											{{ val[1]|raw }})</small>
+									</td>
+								{% elseif key matches '/^\\d+$/' %}
+									<td colspan="3" align="center">{{ val|raw }}</td>
+								{% else %}
+									<td width="180">{{ key|raw }}</td>
+									<td colspan="2">{{ val|raw }}</td>
+								{% endif %}
+							</tr>
+						{% endif %}
+					{% endfor %}
+				{% endfor %}
+			</tbody>
+		</table>
+	</div>
+{% endblock %}