Merge pull request #556 from nachtgeist/master

fix triggering an LE CSR when changing www on a main domain, fixes #526
This commit is contained in:
Michael Kaufmann
2018-06-05 07:52:03 +02:00
committed by GitHub
2 changed files with 18 additions and 3 deletions

View File

@@ -1124,7 +1124,6 @@ if ($page == 'domains' || $page == 'overview') {
}
}
} elseif ($action == 'edit' && $id != 0) {
$result_stmt = Database::prepare("
SELECT `d`.*, `c`.`customerid`
FROM `" . TABLE_PANEL_DOMAINS . "` `d`
@@ -2028,7 +2027,15 @@ if ($page == 'domains' || $page == 'overview') {
} else
if ($result['wwwserveralias'] != $wwwserveralias || $result['letsencrypt'] != $letsencrypt) {
// or when wwwserveralias or letsencrypt was changed
triggerLetsEncryptCSRForAliasDestinationDomain($aliasdomain, $log);
if ($aliasdomain === 0) {
// in case the wwwserveralias is set on a main domain, $aliasdomain is 0
// --> the call just above to triggerLetsEncryptCSRForAliasDestinationDomain
// is a noop...let's repeat it with the domain id of the main domain
triggerLetsEncryptCSRForAliasDestinationDomain($id, $log);
}
}
$log->logAction(ADM_ACTION, LOG_INFO, "edited domain #" . $id);

View File

@@ -773,7 +773,15 @@ if ($page == 'overview') {
triggerLetsEncryptCSRForAliasDestinationDomain($aliasdomain, $log);
} elseif ($result['wwwserveralias'] != $wwwserveralias || $result['letsencrypt'] != $letsencrypt) {
// or when wwwserveralias or letsencrypt was changed
triggerLetsEncryptCSRForAliasDestinationDomain($aliasdomain, $log);
if ($aliasdomain === 0) {
// in case the wwwserveralias is set on a main domain, $aliasdomain is 0
// --> the call just above to triggerLetsEncryptCSRForAliasDestinationDomain
// is a noop...let's repeat it with the domain id of the main domain
triggerLetsEncryptCSRForAliasDestinationDomain($id, $log);
}
}
// check whether LE has been disabled, so we remove the certificate