maketank/Froxlor
2
0
Fork 0
Code Pull Requests Releases Activity

handle the case when gethostbynamel() returns false to act like gethostbyname() in support for multi homed name servers

Browse Source 
Signed-off-by: Michael Kaufmann (d00p) <d00p@froxlor.org>
This commit is contained in:
Michael Kaufmann (d00p)
2016-03-11 21:23:26 +01:00
parent 6b032839ce
commit 579854f5a5
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
scripts/jobs/cron_tasks.inc.dns.10.bind.php
View File

@@ -33,19 +33,23 @@ class bind {
if (Settings::Get('system.nameservers') != '') { if (Settings::Get('system.nameservers') != '') {
$nameservers = explode(',', Settings::Get('system.nameservers')); $nameservers = explode(',', Settings::Get('system.nameservers'));
foreach ($nameservers as $nameserver) { foreach ($nameservers as $nameserver) {
$nameserver = trim($nameserver);
// DNS servers might be multi homed; allow transfer from all ip // DNS servers might be multi homed; allow transfer from all ip
// addresses of the DNS server // addresses of the DNS server
$nameserver_ips = gethostbynamel(trim($nameserver)); $nameserver_ips = gethostbynamel($nameserver);
// ignore invalid responses // append dot to hostname
if (is_array($nameserver_ips)) { if (substr($nameserver, -1, 1) != '.') {
if (substr($nameserver, -1, 1) != '.') { $nameserver.= '.';
$nameserver.= '.';
}
$this->nameservers[] = array(
'hostname' => trim($nameserver),
'ips' => $nameserver_ips
);
} }
// ignore invalid responses
if (!is_array($nameserver_ips)) {
// act like gethostbyname() and return unmodified hostname on error
$nameserver_ips = array($nameserver);
}
$this->nameservers[] = array(
'hostname' => $nameserver,
'ips' => $nameserver_ips
);
} }
} }