maketank/Froxlor
2
0
Fork 0
Code Pull Requests Releases Activity

fix unittests for FroxlorRPC-class again (maybe)

Browse Source 
Signed-off-by: Michael Kaufmann <d00p@froxlor.org>
This commit is contained in:
Michael Kaufmann
2022-02-25 15:42:25 +01:00
parent bbc3644e23
commit 5d7649a274
1 changed files with 23 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/Global/FroxlorRpcTest.php
View File

@@ -15,7 +15,7 @@ class FroxlorRpcTest extends TestCase
{ {
$this->expectExceptionCode(401); $this->expectExceptionCode(401);
$this->expectExceptionMessage("Unauthenticated. Please provide api user credentials."); $this->expectExceptionMessage("Unauthenticated. Please provide api user credentials.");
FroxlorRPC::validateRequest([]); FroxlorRPC::validateRequest("");
} }
public function testValidateAuthInvalid() public function testValidateAuthInvalid()
@@ -24,7 +24,7 @@ class FroxlorRpcTest extends TestCase
$this->expectExceptionMessage("Invalid authorization credentials"); $this->expectExceptionMessage("Invalid authorization credentials");
$_SERVER['PHP_AUTH_USER'] = 'asd'; $_SERVER['PHP_AUTH_USER'] = 'asd';
$_SERVER['PHP_AUTH_PW'] = 'asd'; $_SERVER['PHP_AUTH_PW'] = 'asd';
FroxlorRPC::validateRequest([]); FroxlorRPC::validateRequest("");
} }
public function testValidateAuthAllowFromInvalid() public function testValidateAuthAllowFromInvalid()
@@ -35,17 +35,26 @@ class FroxlorRpcTest extends TestCase
$this->expectExceptionMessage("Invalid authorization credentials"); $this->expectExceptionMessage("Invalid authorization credentials");
$_SERVER['PHP_AUTH_USER'] = 'test'; $_SERVER['PHP_AUTH_USER'] = 'test';
$_SERVER['PHP_AUTH_PW'] = 'test'; $_SERVER['PHP_AUTH_PW'] = 'test';
FroxlorRPC::validateRequest([]); FroxlorRPC::validateRequest("");
} }
public function testInvalidRequestBody() public function testEmptyRequestBody()
{ {
Database::query("UPDATE `api_keys` SET `allowed_from` = '';"); Database::query("UPDATE `api_keys` SET `allowed_from` = '';");
$this->expectExceptionCode(400); $this->expectExceptionCode(400);
$this->expectExceptionMessage("Invalid request body"); $this->expectExceptionMessage("Empty request body.");
$_SERVER['PHP_AUTH_USER'] = 'test'; $_SERVER['PHP_AUTH_USER'] = 'test';
$_SERVER['PHP_AUTH_PW'] = 'test'; $_SERVER['PHP_AUTH_PW'] = 'test';
FroxlorRPC::validateRequest([]); FroxlorRPC::validateRequest("");
}
public function testInvalidJSON()
{
$this->expectExceptionCode(400);
$this->expectExceptionMessage("Invalid JSON Format.");
$_SERVER['PHP_AUTH_USER'] = 'test';
$_SERVER['PHP_AUTH_PW'] = 'test';
FroxlorRPC::validateRequest('asd');
} }
public function testNoCommandGiven() public function testNoCommandGiven()
@@ -54,7 +63,7 @@ class FroxlorRpcTest extends TestCase
$this->expectExceptionMessage("No command given"); $this->expectExceptionMessage("No command given");
$_SERVER['PHP_AUTH_USER'] = 'test'; $_SERVER['PHP_AUTH_USER'] = 'test';
$_SERVER['PHP_AUTH_PW'] = 'test'; $_SERVER['PHP_AUTH_PW'] = 'test';
FroxlorRPC::validateRequest(['cmd' => 'test']); FroxlorRPC::validateRequest(json_encode(['cmd' => 'test']));
} }
public function testInvalidCommandGiven() public function testInvalidCommandGiven()
@@ -63,7 +72,7 @@ class FroxlorRpcTest extends TestCase
$this->expectExceptionMessage("Invalid command"); $this->expectExceptionMessage("Invalid command");
$_SERVER['PHP_AUTH_USER'] = 'test'; $_SERVER['PHP_AUTH_USER'] = 'test';
$_SERVER['PHP_AUTH_PW'] = 'test'; $_SERVER['PHP_AUTH_PW'] = 'test';
FroxlorRPC::validateRequest(['command' => 'Froxlor']); FroxlorRPC::validateRequest(json_encode(['command' => 'Froxlor']));
} }
public function testUnknownCommandGiven() public function testUnknownCommandGiven()
@@ -72,14 +81,14 @@ class FroxlorRpcTest extends TestCase
$this->expectExceptionMessage("Unknown command"); $this->expectExceptionMessage("Unknown command");
$_SERVER['PHP_AUTH_USER'] = 'test'; $_SERVER['PHP_AUTH_USER'] = 'test';
$_SERVER['PHP_AUTH_PW'] = 'test'; $_SERVER['PHP_AUTH_PW'] = 'test';
FroxlorRPC::validateRequest(['command' => 'SomeModule.cmd']); FroxlorRPC::validateRequest(json_encode(['command' => 'SomeModule.cmd']));
} }
public function testCommandOk() public function testCommandOk()
{ {
$_SERVER['PHP_AUTH_USER'] = 'test'; $_SERVER['PHP_AUTH_USER'] = 'test';
$_SERVER['PHP_AUTH_PW'] = 'test'; $_SERVER['PHP_AUTH_PW'] = 'test';
$result = FroxlorRPC::validateRequest(['command' => 'Froxlor.listFunctions']); $result = FroxlorRPC::validateRequest(json_encode(['command' => 'Froxlor.listFunctions']));
$this->assertEquals('Froxlor', $result['command']['class']); $this->assertEquals('Froxlor', $result['command']['class']);
$this->assertEquals('listFunctions', $result['command']['method']); $this->assertEquals('listFunctions', $result['command']['method']);
$this->assertNull($result['params']); $this->assertNull($result['params']);
@@ -89,16 +98,14 @@ class FroxlorRpcTest extends TestCase
{ {
$key = $this->generateKey(); $key = $this->generateKey();
$request = array( $request = array(
'body' => [
'command' => 'Froxlor.listFunctions', 'command' => 'Froxlor.listFunctions',
'params' => $key 'params' => $key
]
); );
$json_request = json_encode($request); $json_request = json_encode($request);
$decoded_request = json_decode($json_request, true); $decoded_request = json_decode($json_request, true);
$decoded_request = $this->stripcslashes_deep($decoded_request); $decoded_request = $this->stripcslashes_deep($decoded_request);
$this->assertEquals($key['key'], $decoded_request['body']['params']['key']); $this->assertEquals($key['key'], $decoded_request['params']['key']);
$this->assertEquals($key['cert'], $decoded_request['body']['params']['cert']); $this->assertEquals($key['cert'], $decoded_request['params']['cert']);
} }
private function stripcslashes_deep($value) private function stripcslashes_deep($value)