maketank/Froxlor
2
0
Fork 0
Code Pull Requests Releases Activity

added check for invalid responses from gethostbynamel

Browse Source 
fixed indent
This commit is contained in:
Kay Zumbusch
2016-03-09 21:01:47 +01:00
parent 52448571ea
commit 641ee1f8a6
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
scripts/jobs/cron_tasks.inc.dns.10.bind.php
View File

@@ -35,14 +35,17 @@ class bind {
foreach ($nameservers as $nameserver) { foreach ($nameservers as $nameserver) {
// DNS servers might be multi homed; allow transfer from all ip // DNS servers might be multi homed; allow transfer from all ip
// addresses of the DNS server // addresses of the DNS server
$nameserver_ips = gethostbynamel(trim($nameserver)); $nameserver_ips = gethostbynamel(trim($nameserver));
if (substr($nameserver, -1, 1) != '.') { // ignore invalid responses
$nameserver.= '.'; if (is_array($nameserver_ips)) {
if (substr($nameserver, -1, 1) != '.') {
$nameserver.= '.';
}
$this->nameservers[] = array(
'hostname' => trim($nameserver),
'ips' => $nameserver_ips
);
} }
$this->nameservers[] = array(
'hostname' => trim($nameserver),
'ips' => $nameserver_ips
);
} }
} }
@@ -235,9 +238,9 @@ class bind {
// put nameservers in allow-transfer // put nameservers in allow-transfer
if (count($this->nameservers) > 0) { if (count($this->nameservers) > 0) {
foreach ($this->nameservers as $ns) { foreach ($this->nameservers as $ns) {
foreach($ns["ips"] as $ip) { foreach($ns["ips"] as $ip) {
$bindconf_file.= ' ' . $ip . ";\n"; $bindconf_file.= ' ' . $ip . ";\n";
} }
} }
} }
// AXFR server #100 // AXFR server #100