diff --git a/install/updates/froxlor/0.10/update_0.10.inc.php b/install/updates/froxlor/0.10/update_0.10.inc.php index dc45add6..0a928293 100644 --- a/install/updates/froxlor/0.10/update_0.10.inc.php +++ b/install/updates/froxlor/0.10/update_0.10.inc.php @@ -530,3 +530,10 @@ if (\Froxlor\Froxlor::isDatabaseVersion('201912100')) { lastStepStatus(0); \Froxlor\Froxlor::updateToDbVersion('201912310'); } + +if (\Froxlor\Froxlor::isDatabaseVersion('201912311')) { + showUpdateStep("Migrate logfiles_format setting"); + Settings::Set('system.logfiles_format', '"' . Settings::Get('system.logfiles_format') . '"'); + lastStepStatus(0); + \Froxlor\Froxlor::updateToDbVersion('201912312'); +} diff --git a/lib/Froxlor/Cron/Http/Apache.php b/lib/Froxlor/Cron/Http/Apache.php index 70b8c4a7..80fc8cc9 100644 --- a/lib/Froxlor/Cron/Http/Apache.php +++ b/lib/Froxlor/Cron/Http/Apache.php @@ -760,7 +760,7 @@ class Apache extends HttpConfigBase $logtype = 'combined'; if (Settings::Get('system.logfiles_format') != '') { $logtype = 'frx_custom'; - $logfiles_text .= ' LogFormat "' . Settings::Get('system.logfiles_format') . '" ' . $logtype . "\n"; + $logfiles_text .= ' LogFormat ' . Settings::Get('system.logfiles_format') . ' ' . $logtype . "\n"; } if (Settings::Get('system.logfiles_type') == '2' && Settings::Get('system.logfiles_format') == '') { $logtype = 'vhost_combined'; diff --git a/lib/Froxlor/Cron/Http/Nginx.php b/lib/Froxlor/Cron/Http/Nginx.php index 678e6812..b2358dd1 100644 --- a/lib/Froxlor/Cron/Http/Nginx.php +++ b/lib/Froxlor/Cron/Http/Nginx.php @@ -71,7 +71,7 @@ class Nginx extends HttpConfigBase } $logtype = 'frx_custom'; - $this->nginx_data[$vhosts_filename] = 'log_format ' . $logtype . ' "' . Settings::Get('system.logfiles_format') . '";' . "\n"; + $this->nginx_data[$vhosts_filename] = 'log_format ' . $logtype . ' ' . Settings::Get('system.logfiles_format') . ';' . "\n"; } } diff --git a/lng/english.lng.php b/lng/english.lng.php index ec2fcea1..b73563af 100644 --- a/lng/english.lng.php +++ b/lng/english.lng.php @@ -339,7 +339,7 @@ $lng['serversettings']['logfiles_directory']['description'] = 'Where should all $lng['serversettings']['logfiles_script']['title'] = 'Custom script to pipe log-files to'; $lng['serversettings']['logfiles_script']['description'] = 'You can specify a script here and use the placeholders {LOGFILE}, {DOMAIN} and {CUSTOMER} if needed. In case you want to use it you will need to activate the Pipe webserver logfiles option too. No prefixed pipe-character is needed.'; $lng['serversettings']['logfiles_format']['title'] = 'Access-log format'; -$lng['serversettings']['logfiles_format']['description'] = 'Enter a custom log-format here according to your webservers specifications, leave empty for default'; +$lng['serversettings']['logfiles_format']['description'] = 'Enter a custom log-format here according to your webservers specifications, leave empty for default. Depending on your format the string must be quoted.
If used with nginx, it will look like log_format frx_custom {CONFIGURED_VALUE}.
If used with Apache, it will look like LogFormat {CONFIGURED_VALUE} frx_custom.
Attention: The code won\'t be checked for any errors. If it contains errors, webserver might not start again!'; $lng['serversettings']['logfiles_type']['title'] = 'Access-log type'; $lng['serversettings']['logfiles_type']['description'] = 'Choose between combined or vhost_combined here.'; $lng['serversettings']['logfiles_piped']['title'] = 'Pipe webserver logfiles to specified script (see above)'; diff --git a/lng/german.lng.php b/lng/german.lng.php index 41379319..6d816b7b 100644 --- a/lng/german.lng.php +++ b/lng/german.lng.php @@ -335,7 +335,7 @@ $lng['serversettings']['logfiles_directory']['description'] = 'Wo sollen die Log $lng['serversettings']['logfiles_script']['title'] = 'Eigenes Script zu dem Log-Files übergeben werden'; $lng['serversettings']['logfiles_script']['description'] = 'Hier kann ein Script an das die Loginhalte übergeben werden hinterlegt und die Platzhalter {LOGFILE}, {DOMAIN} und {CUSTOMER} genutzt werden, sofern nötig. Falls ein Script angegeben wird, muss die Option Webserver Logdateien umleiten gesetzt werden'; $lng['serversettings']['logfiles_format']['title'] = 'Access-Log Format'; -$lng['serversettings']['logfiles_format']['description'] = 'Hier kann ein angepasstes Log-format entsprechend der Webserver-Dokumentation angegeben werden, leer lassen für Standard'; +$lng['serversettings']['logfiles_format']['description'] = 'Hier kann ein angepasstes Log-format entsprechend der Webserver-Dokumentation angegeben werden, leer lassen für Standard. Abhängig vom LogFormat muss die Angabe unter Anführungszeichen stehen.
Wenn verwendet mit nginx, so kann es wie folgt aussehen: log_format frx_custom {EINGESTELLTES_FORMAT}.
Wenn verwendet mit Apache, so kann es wie folgt aussehen: LogFormat {EINGESTELLTES_FORMAT} frx_custom.
ACHTUNG: Der Code wird nicht auf Fehler geprüft. Etwaige Fehler werden auch übernommen und der Webserver könnte nicht mehr starten!'; $lng['serversettings']['logfiles_type']['title'] = 'Access-Log Typ'; $lng['serversettings']['logfiles_type']['description'] = 'Wähle zwischen combined oder vhost_combined.'; $lng['serversettings']['logfiles_piped']['title'] = 'Webserver Logdateien zu eigenem Script umleiten (siehe oben)';