diff --git a/lib/functions/validate/function.validateDomain.php b/lib/functions/validate/function.validateDomain.php index 7f437545..7affb630 100644 --- a/lib/functions/validate/function.validateDomain.php +++ b/lib/functions/validate/function.validateDomain.php @@ -39,22 +39,13 @@ function validateDomain($domainname) // there is a bug in php 5.2.13 - 5.3.2 which // lets filter_var fail if the domain has - // a dash (-) in it. # - if(version_compare("5.2.13", PHP_VERSION, "=") - || version_compare("5.3.2", PHP_VERSION, "=")) - { - $pattern = '/^http:\/\/([a-z0-9]([a-z0-9\-]{0,61}[a-z0-9])?\.)+[a-z]{2,6}$/i'; - if(preg_match($pattern, $domainname_tmp)) - { - return $domainname; - } - } - else - { - if(filter_var($domainname_tmp, FILTER_VALIDATE_URL) !== false && filter_var($domainname_tmp, FILTER_VALIDATE_URL, FILTER_FLAG_PATH_REQUIRED) === false && filter_var($domainname_tmp, FILTER_VALIDATE_URL, FILTER_FLAG_QUERY_REQUIRED) === false) - { - return $domainname; - } + // a dash (-) in it. As the PHP_VERSION constant + // gives also patch-brandings, e.g. '5.3.2-pl0-gentoo' + // we just always use our regex + $pattern = '/^http:\/\/([a-z0-9]([a-z0-9\-]{0,61}[a-z0-9])?\.)+[a-z]{2,6}$/i'; + if(preg_match($pattern, $domainname_tmp)) + { + return $domainname; } return false; } diff --git a/lib/functions/validate/function.validateUrl.php b/lib/functions/validate/function.validateUrl.php index 96e9adfc..65ad0961 100644 --- a/lib/functions/validate/function.validateUrl.php +++ b/lib/functions/validate/function.validateUrl.php @@ -34,21 +34,15 @@ function validateUrl($url) $url = 'http://' . $url; } - if(version_compare("5.2.13", PHP_VERSION, "=") - || version_compare("5.3.2", PHP_VERSION, "=")) + // there is a bug in php 5.2.13 - 5.3.2 which + // lets filter_var fail if the domain has + // a dash (-) in it. As the PHP_VERSION constant + // gives also patch-brandings, e.g. '5.3.2-pl0-gentoo' + // we just always use our regex + $pattern = '/^https?:\/\/([a-z0-9]([a-z0-9\-]{0,61}[a-z0-9])?\.)+[a-z]{2,6}$/i'; + if(preg_match($pattern, $url)) { - $pattern = '/^https?:\/\/([a-z0-9]([a-z0-9\-]{0,61}[a-z0-9])?\.)+[a-z]{2,6}$/i'; - if(preg_match($pattern, $url)) - { - return true; - } - } - else - { - if(filter_var($url, FILTER_VALIDATE_URL, FILTER_FLAG_SCHEME_REQUIRED) !== false) - { - return true; - } + return true; } // not an fqdn