diff --git a/lib/Froxlor/PhpHelper.php b/lib/Froxlor/PhpHelper.php index 2f4c4289..90b30478 100644 --- a/lib/Froxlor/PhpHelper.php +++ b/lib/Froxlor/PhpHelper.php @@ -374,7 +374,7 @@ class PhpHelper $returnval = array(); if (is_array($source)) { $source = array_map('trim', $source); - $source = array_filter($source, function ($value) { + $returnval = array_filter($source, function ($value) { return $value !== ''; }); } else { diff --git a/lib/Froxlor/Settings/Store.php b/lib/Froxlor/Settings/Store.php index 1f4f2a4a..9a578c96 100644 --- a/lib/Froxlor/Settings/Store.php +++ b/lib/Froxlor/Settings/Store.php @@ -242,8 +242,8 @@ class Store $mysql_access_host_array = array_map('trim', explode(',', Settings::Get('system.mysql_access_host'))); $mysql_access_host_array[] = $newfieldvalue; $mysql_access_host_array = array_unique(\Froxlor\PhpHelper::arrayTrim($mysql_access_host_array)); - $mysql_access_host = implode(',', $mysql_access_host_array); \Froxlor\Database\DbManager::correctMysqlUsers($mysql_access_host_array); + $mysql_access_host = implode(',', $mysql_access_host_array); Settings::Set('system.mysql_access_host', $mysql_access_host); } @@ -293,9 +293,11 @@ class Store 'cleanMySQLAccessHost' ), $mysql_access_host_array); - $mysql_access_host_array = array_unique($mysql_access_host_array); + $mysql_access_host_array = array_unique(\Froxlor\PhpHelper::arrayTrim($mysql_access_host_array)); $newfieldvalue = implode(',', $mysql_access_host_array); \Froxlor\Database\DbManager::correctMysqlUsers($mysql_access_host_array); + $mysql_access_host = implode(',', $mysql_access_host_array); + Settings::Set('system.mysql_access_host', $mysql_access_host); } return $returnvalue; diff --git a/tests/Mysqls/MysqlsTest.php b/tests/Mysqls/MysqlsTest.php index 160efcb9..8d521452 100644 --- a/tests/Mysqls/MysqlsTest.php +++ b/tests/Mysqls/MysqlsTest.php @@ -1,10 +1,12 @@ 'serversettings.ipaddress', + 'settinggroup' => 'system', + 'varname' => 'ipaddress' + ); + Store::storeSettingIpAddress('system_system_ipaddress', $fielddata, '82.149.225.47'); + + $mysql_access_hosts = Settings::Get('system.mysql_access_host'); + $this->assertTrue(strpos($mysql_access_hosts, '82.149.225.47') !== false); + } + + /** + * + * @depends testStoreSettingIpAddress + */ public function testGetAllSqlUsers() { \Froxlor\Database\Database::needRoot(true);