- merged settings branch, fixes #134

actions/admin/settings/130.webserver.php

@@ -31,6 +31,7 @@ return array(
 					'option_mode' => 'one',
 					'option_options' => array('apache2' => 'Apache 2', 'lighttpd' => 'ligHTTPd'),
 					'save_method' => 'storeSettingField',
+					'overview_option' => true
 					),
 				'system_apacheconf_vhost' => array(
 					'label' => $lng['serversettings']['apacheconf_vhost'],

actions/admin/settings/170.logger.php

@@ -29,6 +29,7 @@ return array(
 					'type' => 'bool',
 					'default' => false,
 					'save_method' => 'storeSettingField',
+					'overview_option' => true
 					),
 				'logger_severity' => array(
 					'label' => $lng['serversettings']['logger']['severity'],

actions/admin/settings/180.dkim.php

@@ -29,6 +29,7 @@ return array(
 					'type' => 'bool',
 					'default' => false,
 					'save_method' => 'storeSettingFieldInsertBindTask',
+					'overview_option' => true
 					),
 				'dkim_prefix' => array(
 					'label' => $lng['dkim']['dkim_prefix'],

actions/admin/settings/185.spf.php

@@ -26,7 +26,8 @@ return array(
 					'varname' => 'use_spf',
 					'type' => 'bool',
 					'default' => false,
-					'save_method' => 'storeSettingField'
+					'save_method' => 'storeSettingField',
+					'overview_option' => true
 					),
 				'spf_entry' => array(
 					'label' => $lng['spf']['spf_entry'],

actions/admin/settings/190.ticket.php

@@ -30,6 +30,7 @@ return array(
 					'default' => false,
 					'cronmodule' => 'froxlor/ticket',
 					'save_method' => 'storeSettingField',
+					'overview_option' => true
 					),
 				'ticket_noreply_email' => array(
 					'label' => $lng['serversettings']['ticket']['noreply_email'],

actions/admin/settings/200.aps.php

@@ -30,6 +30,7 @@ return array(
 					'default' => false,
 					'cronmodule' => 'froxlor/aps',
 					'save_method' => 'storeSettingField',
+					'overview_option' => true
 					),
 				'aps_items_per_page' => array(
 					'label' => $lng['aps']['packages_per_page'],

admin_settings.php

@@ -31,20 +31,78 @@ if(($page == 'settings' || $page == 'overview')
    && $userinfo['change_serversettings'] == '1')
 {
 	$settings_data = loadConfigArrayDir('./actions/admin/settings/');
-	$settings = loadSettings(&$settings_data, &$db);
+	$settings = loadSettings($settings_data, $db);
 	
 	if(isset($_POST['send'])
 	   && $_POST['send'] == 'send')
 	{
-		if(processForm(&$settings_data, &$_POST, array('filename' => $filename, 'action' => $action, 'page' => $page)))
+		$_part = isset($_GET['part']) ? $_GET['part'] : '';
+
+		if($_part == '')
 		{
+			$_part = isset($_POST['part']) ? $_POST['part'] : '';
+		}
+
+		if($_part != '')
+		{
+			if($_part == 'all')
+			{
+				$settings_all = true;
+				$settings_part = false;
+			}
+			else
+			{
+				$settings_all = false;
+				$settings_part = true;
+			}
+
+			$only_enabledisable = false;
+		}
+		else
+		{
+			$settings_all = false;
+			$settings_part = false;
+			$only_enabledisable = true;
+		}
+		
+		if(processFormEx(
+			$settings_data, 
+			$_POST, 
+			array('filename' => $filename, 'action' => $action, 'page' => $page),
+			$_part,
+			$settings_all,
+			$settings_part,
+			$only_enabledisable
+			)
+		) {
 			standard_success('settingssaved', '', array('filename' => $filename, 'action' => $action, 'page' => $page));
 		}
 	}
 	else
 	{
-		$fields = buildForm(&$settings_data);
+		$_part = isset($_GET['part']) ? $_GET['part'] : '';
-		eval("echo \"" . getTemplate("settings/settings") . "\";");
+		
+		if($_part == '')
+		{
+			$_part = isset($_POST['part']) ? $_POST['part'] : '';
+		}
+
+		$fields = buildFormEx($settings_data, $_part);
+		
+		$settings_page = '';
+		if($_part == '')
+		{
+			eval("\$settings_page .= \"" . getTemplate("settings/settings_overview") . "\";");
+		} 
+		else
+		{
+			eval("\$settings_page .= \"" . getTemplate("settings/settings") . "\";");
+		}
+		
+		eval("echo \"" . getTemplate("settings/settings_form_begin") . "\";");
+		eval("echo \$settings_page;");
+		eval("echo \"" . getTemplate("settings/settings_form_end") . "\";");
+
 	}
 }
 elseif($page == 'rebuildconfigs'

lib/functions/formfields/function.buildFormEx.php

@@ -0,0 +1,62 @@
+<?php
+
+/**
+ * This file is part of the Froxlor project.
+ * Copyright (c) 2010 the Froxlor Team (see authors).
+ *
+ * For the full copyright and license information, please view the COPYING
+ * file that was distributed with this source code. You can also view the
+ * COPYING file online at http://files.froxlor.org/misc/COPYING.txt
+ *
+ * @copyright  (c) the authors
+ * @author     Froxlor team <team@froxlor.org> (2010-)
+ * @license    GPLv2 http://files.froxlor.org/misc/COPYING.txt
+ * @package    Settings
+ * @version    $Id $
+ */
+
+function buildFormEx($form, $part = '')
+{
+	$fields = '';
+
+	if(validateFormDefinition($form))
+	{
+		foreach($form['groups'] as $groupname => $groupdetails)
+		{
+			// show overview
+			if($part == '')
+			{
+				if(isset($groupdetails['title']) && $groupdetails['title'] != '')
+				{
+					$fields .= getFormOverviewGroupOutput($groupname, $groupdetails);
+				}
+			}
+			// only show one section
+			elseif($part != '' && ($groupname == $part || $part == 'all'))
+			{
+				if(isset($groupdetails['title']) && $groupdetails['title'] != '')
+				{
+					$fields .= getFormGroupOutput($groupname, $groupdetails);
+				}
+				
+				if(validateFieldDefinition($groupdetails))
+				{
+					// Prefetch form fields
+					foreach($groupdetails['fields'] as $fieldname => $fielddetails)
+					{
+						$groupdetails['fields'][$fieldname] = array_merge_prefix($fielddetails, $fielddetails['type'], prefetchFormFieldData($fieldname, $fielddetails));
+						$form['groups'][$groupname]['fields'][$fieldname] = $groupdetails['fields'][$fieldname];
+					}
+	
+					// Collect form field output
+					foreach($groupdetails['fields'] as $fieldname => $fielddetails)
+					{
+						$fields .= getFormFieldOutput($fieldname, $fielddetails);
+					}
+				}
+			}
+		}
+	}
+
+	return $fields;
+}

lib/functions/formfields/function.getFormFieldData.php

@@ -17,7 +17,7 @@
  * @version    $Id$
  */
 
-function getFormFieldData($fieldname, $fielddata, $input)
+function getFormFieldData($fieldname, $fielddata, &$input)
 {
 	if(is_array($fielddata) && isset($fielddata['type']) && $fielddata['type'] != '' && function_exists('getFormFieldData' . ucfirst($fielddata['type'])))
 	{

lib/functions/formfields/function.getFormGroupOutput.php

@@ -23,3 +23,54 @@ function getFormGroupOutput($groupname, $groupdetails)
 	eval("\$group = \"" . getTemplate("settings/settings_group") . "\";");
 	return $group;
 }
+
+function getFormOverviewGroupOutput($groupname, $groupdetails)
+{
+	global $lng, $settings, $filename, $s;
+	
+	$group = '';
+	$title = $groupdetails['title'];
+	$part = $groupname;
+
+	$activated = true;
+	$option = '';
+	if(isset($groupdetails['fields']))
+	{
+		foreach($groupdetails['fields'] as $fieldname => $fielddetails)
+		{
+			if(isset($fielddetails['overview_option'])
+				&& $fielddetails['overview_option'] == true
+			) {
+				if($fielddetails['type'] != 'option'
+					&& $fielddetails['type'] != 'bool')
+				{
+					standard_error('overviewsettingoptionisnotavalidfield');
+				}
+
+				if($fielddetails['type'] == 'option')
+				{
+					$options_array = $fielddetails['option_options'];		
+					$options = '';
+					foreach($options_array as $value => $vtitle)
+					{
+						$options .= makeoption($vtitle, $value, $settings[$fielddetails['settinggroup']][$fielddetails['varname']]);
+					}
+					$option.= $fielddetails['label'].': ';
+					$option.= '<select class="dropdown_noborder" name="'.$fieldname.'">';
+					$option.= $options;
+					$option.= '</select>';
+					$activated = true;
+				}
+				else
+				{
+					$option.= $lng['admin']['activated'].':&nbsp;';
+					$option.= makeyesno($fieldname, '1', '0', $settings[$fielddetails['settinggroup']][$fielddetails['varname']]);
+					$activated = (int)$settings[$fielddetails['settinggroup']][$fielddetails['varname']];
+				}
+			}
+		}
+	}
+
+	eval("\$group = \"" . getTemplate("settings/settings_overviewgroup") . "\";");
+	return $group;
+}

lib/functions/formfields/function.processForm.php

@@ -17,7 +17,7 @@
  * @version    $Id$
  */
 
-function processForm($form, $input, $url_params = array())
+function processForm(&$form, &$input, $url_params = array())
 {
 	if(validateFormDefinition($form))
 	{
@@ -45,7 +45,7 @@ function processForm($form, $input, $url_params = array())
 				// Validate fields
 				foreach($groupdetails['fields'] as $fieldname => $fielddetails)
 				{
-					$newfieldvalue = getFormFieldData($fieldname, $fielddetails, &$input);
+					$newfieldvalue = getFormFieldData($fieldname, $fielddetails, $input);
 			
 					if($newfieldvalue != $fielddetails['value'])
 					{
@@ -143,3 +143,166 @@ function processForm($form, $input, $url_params = array())
 		return saveForm($form, $saved_fields);
 	}
 }
+
+function processFormEx(&$form, &$input, $url_params = array(), $part, $settings_all, $settings_part, $only_enabledisable)
+{
+	if(validateFormDefinition($form))
+	{
+		$submitted_fields = array();
+		$changed_fields = array();
+		$saved_fields = array();
+
+		foreach($form['groups'] as $groupname => $groupdetails)
+		{
+			if(($settings_part && $part == $groupname)
+				|| $settings_all
+				|| $only_enabledisable
+			){
+				if(validateFieldDefinition($groupdetails))
+				{
+					// Prefetch form fields
+					foreach($groupdetails['fields'] as $fieldname => $fielddetails)
+					{
+						if(!$only_enabledisable
+							|| ($only_enabledisable && isset($fielddetails['overview_option']))
+						) {
+							$groupdetails['fields'][$fieldname] = array_merge_prefix($fielddetails, $fielddetails['type'], prefetchFormFieldData($fieldname, $fielddetails));
+							$form['groups'][$groupname]['fields'][$fieldname] = $groupdetails['fields'][$fieldname];
+						}
+					}
+				}
+			}
+		}
+		
+		foreach($form['groups'] as $groupname => $groupdetails)
+		{
+			if(($settings_part && $part == $groupname)
+				|| $settings_all
+				|| $only_enabledisable
+			){			
+				if(validateFieldDefinition($groupdetails))
+				{
+					// Validate fields
+					foreach($groupdetails['fields'] as $fieldname => $fielddetails)
+					{
+						if(!$only_enabledisable
+							|| ($only_enabledisable && isset($fielddetails['overview_option']))
+						) {
+							$newfieldvalue = getFormFieldData($fieldname, $fielddetails, $input);
+					
+							if($newfieldvalue != $fielddetails['value'])
+							{
+								if(($error = validateFormField($fieldname, $fielddetails, $newfieldvalue)) !== true)
+								{
+									standard_error($error, $fieldname);
+								}
+								else
+								{
+									$changed_fields[$fieldname] = $newfieldvalue;
+								}
+							}
+		
+							$submitted_fields[$fieldname] = $newfieldvalue;
+						}
+					}
+				}
+			}
+		}
+
+		foreach($form['groups'] as $groupname => $groupdetails)
+		{
+			if(($settings_part && $part == $groupname)
+				|| $settings_all
+				|| $only_enabledisable
+			){
+				if(validateFieldDefinition($groupdetails))
+				{
+					// Check fields for plausibility
+					foreach($groupdetails['fields'] as $fieldname => $fielddetails)
+					{
+						if(!$only_enabledisable
+							|| ($only_enabledisable && isset($fielddetails['overview_option']))
+						) {
+							if(($plausibility_check = checkPlausibilityFormField($fieldname, $fielddetails, $submitted_fields[$fieldname], $submitted_fields)) !== false)
+							{
+								if(is_array($plausibility_check) && isset($plausibility_check[0]))
+								{
+									if($plausibility_check[0] == FORMFIELDS_PLAUSIBILITY_CHECK_OK)
+									{
+										// Nothing to do here, everything's okay
+									}
+									elseif($plausibility_check[0] == FORMFIELDS_PLAUSIBILITY_CHECK_ERROR)
+									{
+										unset($plausibility_check[0]);
+										$error = $plausibility_check[1];
+										unset($plausibility_check[1]);
+										$targetname = implode(' ', $plausibility_check);
+										standard_error($error, $targetname);
+									}
+									elseif($plausibility_check[0] == FORMFIELDS_PLAUSIBILITY_CHECK_QUESTION)
+									{
+										unset($plausibility_check[0]);
+										$question = $plausibility_check[1];
+										unset($plausibility_check[1]);
+										$targetname = implode(' ', $plausibility_check);
+										if(!isset($input[$question]))
+										{
+											if(is_array($url_params) && isset($url_params['filename']))
+											{
+												$filename = $url_params['filename'];
+												unset($url_params['filename']);
+											}
+											else
+											{
+												$filename = '';
+											}
+											ask_yesno($question, $filename, array_merge($url_params, $submitted_fields, array($question => $question)), $targetname);
+										}
+									}
+									else
+									{
+										standard_error('plausibilitychecknotunderstood');
+									}
+								}
+							}
+						}
+					}
+				}
+			}
+		}
+
+		foreach($form['groups'] as $groupname => $groupdetails)
+		{
+			if(($settings_part && $part == $groupname)
+				|| $settings_all
+				|| $only_enabledisable
+			){
+				if(validateFieldDefinition($groupdetails))
+				{
+					// Save fields
+					foreach($groupdetails['fields'] as $fieldname => $fielddetails)
+					{
+						if(!$only_enabledisable
+							|| ($only_enabledisable && isset($fielddetails['overview_option']))
+						) {
+							if(isset($changed_fields[$fieldname]))
+							{
+								if(($saved_field = saveFormField($fieldname, $fielddetails, manipulateFormFieldData($fieldname, $fielddetails, $changed_fields[$fieldname]))) !== false)
+								{
+									$saved_fields = array_merge($saved_fields, $saved_field);
+								}
+								else
+								{
+									standard_error('errorwhensaving', $fieldname);
+								}
+							}
+						}
+					}
+				}
+			}
+		}
+
+		// Save form
+		return saveForm($form, $saved_fields);
+	}
+}

lib/functions/settings/function.loadSettings.php

@@ -17,7 +17,7 @@
  * @version    $Id$
  */
 
-function loadSettings($settings_data, $db)
+function loadSettings(&$settings_data, $db)
 {
 	$settings = array();
 

lib/init.php

@@ -150,7 +150,7 @@ if(get_magic_quotes_gpc())
  */
 
 $settings_data = loadConfigArrayDir('./actions/admin/settings/');
-$settings = loadSettings(&$settings_data, &$db);
+$settings = loadSettings($settings_data, $db);
 
 /*
  * when upgrading from syscp, the header-graphic gets lost

lng/english.lng.php

@@ -752,7 +752,7 @@ $lng['serversettings']['logger']['severity'] = 'Logging level';
 $lng['admin']['logger']['normal'] = 'normal';
 $lng['admin']['logger']['paranoid'] = 'paranoid';
 $lng['serversettings']['logger']['types']['title'] = 'Log-type(s)';
-$lng['serversettings']['logger']['types']['description'] = 'Specify logtypes seperated by comma.<br />Available logtypes are: syslog, file, mysql';
+$lng['serversettings']['logger']['types']['description'] = 'Specify logtypes. To select multiple types, hold down CTRL while selecting.<br />Available logtypes are: syslog, file, mysql';
 $lng['serversettings']['logger']['logfile'] = 'Logfile path including filename';
 $lng['error']['logerror'] = 'Log-Error: %s';
 $lng['serversettings']['logger']['logcron'] = 'Log cronjobs (one run)';
@@ -1356,5 +1356,7 @@ $lng['customer']['mysql_add']['infomail_body']['main'] = "Hello {CUST_NAME},\n\n
 $lng['error']['domains_cantdeletedomainwithapsinstances'] = 'You cannot delete a domain which is used by an installed APS package. You have to uninstall it first.';
 $lng['serversettings']['awstats_path'] = 'Path to AWStats \'awstats_buildstaticpages.pl\'';
 $lng['serversettings']['awstats_conf'] = 'AWStats configuration path';
+$lng['error']['overviewsettingoptionisnotavalidfield'] = 'Woops, a field that should be displayed as an option in the settings-overview is not an excepted type. You can blame the developers for this. This should not happen!';
+$lng['admin']['configfiles']['compactoverview'] = 'Compact-overview';
 
 ?>

lng/german.lng.php

@@ -756,7 +756,7 @@ $lng['serversettings']['logger']['severity'] = 'Logging Level';
 $lng['admin']['logger']['normal'] = 'Normal';
 $lng['admin']['logger']['paranoid'] = 'Paranoid';
 $lng['serversettings']['logger']['types']['title'] = 'Log-Art(en)';
-$lng['serversettings']['logger']['types']['description'] = 'Tragen Sie hier die gew&uuml;nschten Logtypen kommagetrennt ein.<br />M&ouml;gliche Logtypen sind: syslog, file, mysql';
+$lng['serversettings']['logger']['types']['description'] = 'W&auml;hlen Sie hier die gew&uuml;nschten Logtypen. F&uuml;r Mehrfachauswahl, halten Sie w&auml;ghrend der Auswahl STRG gedr&uuml;ckt<br />M&ouml;gliche Logtypen sind: syslog, file, mysql';
 $lng['serversettings']['logger']['logfile'] = 'Log-Datei Pfad inklusive Dateinamen';
 $lng['error']['logerror'] = 'Log-Fehler: %s';
 $lng['serversettings']['logger']['logcron'] = 'Log Cronjobs (einen Durchgang)';
@@ -1336,6 +1336,7 @@ $lng['customer']['mysql_add']['infomail_body']['main'] = "Hallo {CUST_NAME},\n\n
 $lng['error']['domains_cantdeletedomainwithapsinstances'] = 'Sie k&ouml;nnen keine Domain l&ouml;schen, die noch von APS Paketen verwendet wird. L&ouml;schen Sie zuerst alle installierten APS Pakete dieser Domain.';
 $lng['serversettings']['awstats_path'] = 'Pfad zu AWStats \'awstats_buildstaticpages.pl\'';
 $lng['serversettings']['awstats_conf'] = 'AWStats Konfigurations-Pfad';
+$lng['admin']['configfiles']['compactoverview'] = 'Kompakt-&Uuml;bersicht';
 
 $lng['mysql']['mysql_server'] = 'MySQL-Server';
 $lng['admin']['ipsandports']['webserverdefaultconfig'] = 'Webserver Standard Konfiguration';

templates/admin/settings/settings.tpl

@@ -1,12 +1,7 @@
-$header
-	<form method="post" action="$filename">
-		<input type="hidden" name="s" value="$s" />
-		<input type="hidden" name="page" value="$page" />
-		<input type="hidden" name="action" value="$action" />
-		<input type="hidden" name="send" value="send" />
 		<table cellpadding="5" cellspacing="4" border="0" align="center" class="maintable">
 			<tr>
-				<td class="maintitle" colspan="2"><b><img src="images/title.gif" alt="" />&nbsp;{$lng['admin']['serversettings']}</b></td>
+				<td class="maintitle" colspan="2"><b><img src="images/title.gif" alt="" />&nbsp;{$lng['admin']['serversettings']}</b>
+				[<a href="$filename?page=overview&amp;part=&amp;s=$s">{$lng['admin']['configfiles']['compactoverview']}</a>]</td>
 			</tr>
 			$fields
 			<tr>
@@ -15,7 +10,3 @@ $header
 				</td>
 			</tr>
 		</table>
-	</form>
-	<br />
-	<br />
-$footer

templates/admin/settings/settings_form_begin.tpl

@@ -0,0 +1,6 @@
+$header
+	<form method="post" action="$filename">
+		<input type="hidden" name="send" value="send" />
+		<input type="hidden" name="s" value="$s" />
+		<input type="hidden" name="page" value="$page" />
+		<input type="hidden" name="action" value="$action" />

templates/admin/settings/settings_form_end.tpl

@@ -0,0 +1,7 @@
+		<if $_part != ''>
+			<input type="hidden" name="part" value="{$_part}" />
+		</if>
+	</form>
+	<br />
+	<br />
+$footer

templates/admin/settings/settings_overview.tpl

@@ -0,0 +1,14 @@
+		<table cellpadding="5" cellspacing="4" border="0" align="center" class="maintable_60">
+			<tr>
+				<td class="maintitle" align="center" colspan="3">
+					<b><img src="images/title.gif" alt="" />&nbsp;{$lng['admin']['configfiles']['serverconfiguration']}</b>
+					[<a href="$filename?page=overview&amp;part=all&amp;s=$s">{$lng['admin']['configfiles']['overview']}</a>]
+				</td>
+			</tr>
+			$fields
+			<tr>
+				<td class="maintitle_apply_right" nowrap="nowrap" colspan="3">
+					<input class="bottom" type="reset" value="{$lng['panel']['reset']}" />&nbsp;<input class="bottom" type="submit" value="{$lng['panel']['save']}" />
+				</td>
+			</tr>
+		</table>

templates/admin/settings/settings_overviewgroup.tpl

@@ -0,0 +1,11 @@
+			<tr>
+				<td class="maintitle_apply_left">
+					<b><img src="images/title.gif" alt="" />&nbsp;{$title}</b>
+				</td>
+				<td class="main_field_display_small" nowrap="nowrap">{$option}</td>
+				<td class="main_field_display_small" nowrap="nowrap">
+					<if $activated == 1>
+						<a href="$filename?page=overview&amp;part=$part&amp;s=$s">{$lng['admin']['configfiles']['serverconfiguration']}</a>
+					</if>
+				</td>
+			</tr>