diff --git a/admin_logger.php b/admin_logger.php index 34b519e1..3d317533 100644 --- a/admin_logger.php +++ b/admin_logger.php @@ -83,7 +83,7 @@ if ($page == 'log' && $userinfo['change_serversettings'] == '1') { case \Froxlor\FroxlorLogger::LOGIN_ACTION: $_action = $lng['logger']['login']; break; - case LOG_ERROR: + case \Froxlor\FroxlorLogger::LOG_ERROR: $_action = $lng['logger']['intern']; break; default: diff --git a/customer_logger.php b/customer_logger.php index 01da2095..197e99a2 100644 --- a/customer_logger.php +++ b/customer_logger.php @@ -96,7 +96,7 @@ if ($page == 'log') { case \Froxlor\FroxlorLogger::LOGIN_ACTION: $_action = $lng['logger']['login']; break; - case LOG_ERROR: + case \Froxlor\FroxlorLogger::LOG_ERROR: $_action = $lng['logger']['intern']; break; default: diff --git a/lib/Froxlor/Cron/Http/HttpConfigBase.php b/lib/Froxlor/Cron/Http/HttpConfigBase.php index b1c68993..c927423d 100644 --- a/lib/Froxlor/Cron/Http/HttpConfigBase.php +++ b/lib/Froxlor/Cron/Http/HttpConfigBase.php @@ -34,7 +34,7 @@ class HttpConfigBase if (Settings::Get('system.leenabled') == 1) { \Froxlor\FroxlorLogger::getInstanceOf()->logAction(\Froxlor\FroxlorLogger::CRON_ACTION, LOG_INFO, 'Running Let\'s Encrypt cronjob prior to regenerating webserver config files'); \Froxlor\Cron\Http\LetsEncrypt\AcmeSh::$no_inserttask = true; - \Froxlor\Cron\Http\LetsEncrypt\AcmeSh::run(); + \Froxlor\Cron\Http\LetsEncrypt\AcmeSh::run(true); // set last run timestamp of cronjob \Froxlor\System\Cronjob::updateLastRunOfCron('letsencrypt'); } diff --git a/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php b/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php index 98762abb..e0967ca0 100644 --- a/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php +++ b/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php @@ -45,10 +45,11 @@ class AcmeSh extends \Froxlor\Cron\FroxlorCron public static $no_inserttask = false; - public static function run() + public static function run($internal = false) { - if (! defined('CRON_IS_FORCED') && ! defined('CRON_DEBUG_FLAG')) { - FroxlorLogger::getInstanceOf()->logAction(FroxlorLogger::CRON_ACTION, LOG_WARNING, "Let's Encrypt cronjob is combined with regeneration of webserver configuration files.\nFor debugging purposes you can use the --debug switch and/or the --force switch to run the cron manually."); + if (! defined('CRON_IS_FORCED') && ! defined('CRON_DEBUG_FLAG') && $internal == false) { + //FroxlorLogger::getInstanceOf()->logAction(FroxlorLogger::CRON_ACTION, LOG_WARNING, "Let's Encrypt cronjob is combined with regeneration of webserver configuration files.\nFor debugging purposes you can use the --debug switch and/or the --force switch to run the cron manually."); + return 0; } self::checkInstall(); diff --git a/lib/Froxlor/Cron/MasterCron.php b/lib/Froxlor/Cron/MasterCron.php index b640aa45..3179efb0 100644 --- a/lib/Froxlor/Cron/MasterCron.php +++ b/lib/Froxlor/Cron/MasterCron.php @@ -102,23 +102,7 @@ class MasterCron extends \Froxlor\Cron\FroxlorCron $cronfile::run(); } } - - if ($tasks_cnt['jobcnt'] > 0) { - if (\Froxlor\Settings::Get('system.nssextrausers') == 1) { - \Froxlor\Cron\System\Extrausers::generateFiles(self::$cronlog); - } - - // clear NSCD cache if using fcgid or fpm, #1570 - not needed for nss-extrausers - if ((\Froxlor\Settings::Get('system.mod_fcgid') == 1 || (int) \Froxlor\Settings::Get('phpfpm.enabled') == 1) && \Froxlor\Settings::Get('system.nssextrausers') == 0) { - $false_val = false; - \Froxlor\FileDir::safe_exec('nscd -i passwd 1> /dev/null', $false_val, array( - '>' - )); - \Froxlor\FileDir::safe_exec('nscd -i group 1> /dev/null', $false_val, array( - '>' - )); - } - } + self::refreshUsers($tasks_cnt['jobcnt']); } /** @@ -133,6 +117,26 @@ class MasterCron extends \Froxlor\Cron\FroxlorCron self::shutdown(); } + private static function refreshUsers($jobcount = 0) + { + if ($jobcount > 0) { + if (\Froxlor\Settings::Get('system.nssextrausers') == 1) { + \Froxlor\Cron\System\Extrausers::generateFiles(self::$cronlog); + } + + // clear NSCD cache if using fcgid or fpm, #1570 - not needed for nss-extrausers + if ((\Froxlor\Settings::Get('system.mod_fcgid') == 1 || (int) \Froxlor\Settings::Get('phpfpm.enabled') == 1) && \Froxlor\Settings::Get('system.nssextrausers') == 0) { + $false_val = false; + \Froxlor\FileDir::safe_exec('nscd -i passwd 1> /dev/null', $false_val, array( + '>' + )); + \Froxlor\FileDir::safe_exec('nscd -i group 1> /dev/null', $false_val, array( + '>' + )); + } + } + } + private static function init() { if (@php_sapi_name() != 'cli' && @php_sapi_name() != 'cgi' && @php_sapi_name() != 'cgi-fcgi') {