diff --git a/actions/admin/settings/140.statistics.php b/actions/admin/settings/140.statistics.php index 7cc59b49..23b51a63 100644 --- a/actions/admin/settings/140.statistics.php +++ b/actions/admin/settings/140.statistics.php @@ -34,7 +34,7 @@ return array( 2 => $lng['admin']['webalizer']['veryquiet'] ), 'save_method' => 'storeSettingField', - 'visible' => \Froxlor\Settings::Get('system.awstats_enabled') == 1 + 'visible' => \Froxlor\Settings::Get('system.awstats_enabled') == 0 ), 'system_awstats_enabled' => array( 'label' => $lng['serversettings']['awstats_enabled'], @@ -51,7 +51,8 @@ return array( 'type' => 'string', 'string_type' => 'dir', 'default' => '/usr/bin/', - 'save_method' => 'storeSettingField' + 'save_method' => 'storeSettingField', + 'visible' => \Froxlor\Settings::Get('system.awstats_enabled') == 1 ), 'system_awstats_awstatspath' => array( 'label' => $lng['serversettings']['awstats_awstatspath'], @@ -60,7 +61,8 @@ return array( 'type' => 'string', 'string_type' => 'dir', 'default' => '/usr/bin/', - 'save_method' => 'storeSettingField' + 'save_method' => 'storeSettingField', + 'visible' => \Froxlor\Settings::Get('system.awstats_enabled') == 1 ), 'system_awstats_conf' => array( 'label' => $lng['serversettings']['awstats_conf'], @@ -69,7 +71,8 @@ return array( 'type' => 'string', 'string_type' => 'dir', 'default' => '/etc/awstats/', - 'save_method' => 'storeSettingField' + 'save_method' => 'storeSettingField', + 'visible' => \Froxlor\Settings::Get('system.awstats_enabled') == 1 ), 'system_awstats_icons' => array( 'label' => $lng['serversettings']['awstats_icons'], @@ -78,7 +81,8 @@ return array( 'type' => 'string', 'string_type' => 'dir', 'default' => '/usr/share/awstats/icon/', - 'save_method' => 'storeSettingField' + 'save_method' => 'storeSettingField', + 'visible' => \Froxlor\Settings::Get('system.awstats_enabled') == 1 ), 'system_awstats_logformat' => array( 'label' => $lng['serversettings']['awstats']['logformat'], @@ -86,7 +90,8 @@ return array( 'varname' => 'awstats_logformat', 'type' => 'string', 'default' => '1', - 'save_method' => 'storeSettingField' + 'save_method' => 'storeSettingField', + 'visible' => \Froxlor\Settings::Get('system.awstats_enabled') == 1 ) ) ) diff --git a/tests/Customers/CustomersTest.php b/tests/Customers/CustomersTest.php index 26100f3e..23ff8459 100644 --- a/tests/Customers/CustomersTest.php +++ b/tests/Customers/CustomersTest.php @@ -61,12 +61,17 @@ class CustomersTest extends TestCase $this->assertEquals(15, $result['subdomains']); $this->assertEquals('secret', $result['custom_notes']); - // validate that the std-subdomain has been added - $json_result = SubDomains::getLocal($admin_userdata, array( - 'id' => $result['standardsubdomain'] - ))->get(); - $result = json_decode($json_result, true)['data']; - $this->assertEquals('test1.dev.froxlor.org', $result['domain']); + $stdsubdomain = $result['standardsubdomain'] ?? false; + if (! $stdsubdomain) { + $this->fail('No standardsubdomain where there should be one'); + } else { + // validate that the std-subdomain has been added + $json_result = SubDomains::getLocal($admin_userdata, array( + 'id' => $result['standardsubdomain'] + ))->get(); + $result = json_decode($json_result, true)['data']; + $this->assertEquals('test1.dev.froxlor.org', $result['domain']); + } } public function testAdminCustomersAddEmptyMail() diff --git a/tests/Domains/DomainsTest.php b/tests/Domains/DomainsTest.php index b3fe32f9..edc65799 100644 --- a/tests/Domains/DomainsTest.php +++ b/tests/Domains/DomainsTest.php @@ -38,6 +38,7 @@ class DomainsTest extends TestCase $result = json_decode($json_result, true)['data']; $this->assertEquals($customer_userdata['documentroot'] . 'test.local/', $result['documentroot']); $this->assertTrue(in_array('TLSv1.3', explode(",", $result['ssl_protocols']))); + $this->assertEquals('0', $result['isemaildomain']); } /**