linting

manifests/common.pp

@@ -1,10 +1,10 @@
 class puppet::common ($ensure = 'present') {
-  package { 'facter':
-    ensure => $ensure ? {
-      'present' => 'latest',
-      default   => $ensure,
-    }
+  $pkg_ens = $ensure ? {
+    'present' => 'latest',
+    default   => $ensure,
   }
+
+  package { 'facter': ensure => $pkg_ens }
   $ens_dir = $ensure ? {
     'present' => 'directory',
     default   => $ensure,
@@ -18,16 +18,15 @@ class puppet::common ($ensure = 'present') {
       '/etc/facter',
       $facts_d]:
       ensure => $ens_dir,
-      mode   => 0755,
-      owner  => root,
-      group  => root;
+      mode   => '0755',
+      owner  => 'root',
+      group  => 'root';
 
     "${::puppet_vardir}/exported":
       ensure => $ens_dir;
   }
 
   # add facter variable to custom facts.
-  file { '/etc/profile.d/puppet.sh':
-    content => "export FACTERLIB=\"${factpath}\"\n",
+  file { '/etc/profile.d/puppet.sh': content => "export FACTERLIB=\"${::factpath}\"\n",
   }
 }