Make the side navigation more styleable

Signed-off-by: Roman Schmerold (BNoiZe) <bnoize@froxlor.org>

lib/functions/output/function.buildNavigation.php

@@ -71,10 +71,12 @@ function buildNavigation($navigation, $userinfo) {
 						} elseif (isset($_GET['page']) && substr_count($element['url'], "page=" . $_GET['page']) > 0 && substr_count($element['url'], basename($_SERVER["SCRIPT_FILENAME"])) > 0 && substr_count($element['url'], "action=") == 0 && !isset($_GET['action'])) {
 							$active = ' active';
 						}
-
-						$completeLink = '<a href="' . htmlspecialchars($element['url']) . '"' . $target . ' class="menu' . $active . '">' . $element['label'] . '</a>';
+						
+						$navurl = htmlspecialchars($element['url']);
+						$navlabel = $element['label'];
 					} else {
-						$completeLink = $element['label'];
+						$navurl = htmlspecialchars($element['url']);
+						$navlabel = $element['label'];
 					}
 
 					eval("\$navigation_links .= \"" . getTemplate("navigation_link", 1) . "\";");
@@ -82,6 +84,7 @@ function buildNavigation($navigation, $userinfo) {
 			}
 
 			if ($navigation_links != '') {
+				$target = '';
 				if (isset($box['url']) && trim($box['url']) != '') {
 					// append sid only to local
 
@@ -95,14 +98,15 @@ function buildNavigation($navigation, $userinfo) {
 						}
 					}
 
-					$target = '';
 					if (isset($box['new_window']) && $box['new_window'] == true) {
 						$target = ' target="_blank"';
 					}
-
-					$completeLink = '<a href="' . htmlspecialchars($box['url']) . '"' . $target . ' class="menu">' . $box['label'] . '</a>';
+					
+					$navurl = htmlspecialchars($box['url']);
+					$navlabel = $box['label'];
 				} else {
-					$completeLink = $box['label'];
+					$navurl = "#";
+					$navlabel = $box['label'];
 				}
 
 				eval("\$returnvalue .= \"" . getTemplate("navigation_element", 1) . "\";");

templates/Sparkle/navigation_element.tpl

@@ -1,5 +1,11 @@
 <div class="menuelement">
-	<h4>{$completeLink}</h4>
+	<h4>
+		<if $navurl != '#'>
+			<a href="{$navurl}" {$target} class="menu">{$navlabel}</a>
+		<else>
+			{$navlabel}
+		</if>
+	</h4>
 	<ul>
 		{$navigation_links}
 	</ul>

templates/Sparkle/navigation_link.tpl

@@ -1 +1 @@
-	<li>{$completeLink}</li>
+	<li><a href="{$navurl}" {$target} class="menu {$active}">{$navlabel}</a></li>